[IMP] session_db: add method delete_from_identifiers

[maq-adhoc]

Added the delete_from_identifiers method to PGSessionStore.
This method allows bulk deletion of session records from the http_sessions table based on a list of session identifiers (sid). It is triggered from the backend via the "Revoke" button

[OCA-git-bot]

Hi @sbidoul,
some modules you are maintaining are being modified, check this out!

[sbidoul]

Ah I had not noticed delete_from_identifiers was there in 18.0 too.

If I'm not mistaken, the identifiers provided to that method are the first 42 characters of the sid.

It handled that in the 19.0 migration. You may want to review #3413 and then extract the relevant part for 18.

[maq-adhoc]

@sbidoul Perfect, I backported 19. Regards

[sbidoul]

_sha1_re is not the same regex as _session_identifier_re. Why do you change this?

[maq-adhoc]

hi @sbidoul
The module imports the sessions class from odoo.tools._vendor import sessions.

The generate_key method it calls is this one: https://github.com/odoo/odoo/blob/18.0/odoo/tools/_vendor/sessions.py#L33-L37 which creates a SHA (40 characters) and not a 42-character identifier.

I understand that we could modify the FilesystemSessionStore class to inherit from FilesystemSessionStore (https://github.com/odoo/odoo/blob/18.0/odoo/http.py#L911) and ensure consistent behavior. However, we would have to remove the validations to avoid errors with existing sessions.

Since we are on a stable version with many productive installations, I prefer to be conservative with the changes. I look forward to hearing your opinion.

[sbidoul]

Ah, I see. And in 19, we don't have that problem because we use the generate_key method from FileSystemSessionStore here:

server-tools/session_db/pg_session_store.py

Line 142 in 7937302

generate_key = http.FilesystemSessionStore.generate_key

Is that right?

So maybe we should do the same here, and support both regexes in delete_from_identifiers?

[tarteo]

Why should we validate the input anyways?

Isn't it faster to do an IN operation?
https://github.com/OCA/server-tools/pull/3662/changes#diff-d813321f73ce1687539ce0923c3e35057a0c7c2be7ae3f11ae43a30bcf6cd1bbR158-R166

[tarteo]

@maq-adhoc Can you take a look at #3662 and review if you have time?
This PR solves multiple issues, and the implementation it consistent with 19.0.
I resused a snippet (sessions._sha1_re.match(identifier):) from this PR, so I will add you to the contributors if you like.
It also includes a few additional tests covering these methods.