Pgstar residuals take 2#1028
Open
matthiasfabry wants to merge 7 commits into
Open
Conversation
TODO: - pass arguments - create arguments in pgstar namelist - create grid pgstar
Closed
Contributor
|
@matthiasfabry regarding the color palette (from the other now closed PR), maybe it's easier to use the existing color palette (at least for the max residual across cells for each equation, not sure this would work easily for the colorbar)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I cherry picked only the relevant commits (removing the hackathon changes)
See #1027 for original.
What remains to be done is checking if the device drivers can be updated and if that fixes plotting to pngs.