Pgplot residuals#1027
Conversation
TODO: - pass arguments - create arguments in pgstar namelist - create grid pgstar
…siduals # Conflicts: # star/private/pgstar_ctrls_io.f90 # star/private/pgstar_kipp_residuals.f90
|
Thanks @matthiasfabry! Is there a strong dependence on the inlist parameters? I'd expect only the |
|
I'm not sure what you mean? |
|
ok, sorry, I misunderstood. Indeed, I would maybe base this on main rather than the hackathon branch, and make it independent of the hackathon branch completely since nothing of the hackathon is necessary for these pgplots? |
|
That's right, I'll see if can do the rebasing. @rhdtownsend I cannot get saving to files to work because apparently, in the PNG device driver, |
|
I cherry-picked the relevant commits on top of main; making a new PR: |
|
closing to other PR with cherry picked commits #1028 |
Based on @mathren initial work of bringing some diagnostic residual plots.
I had to refactor quite a lot to allow for our typical user controls.
I still need to do a few things, such as fix file printing, and possible allow for restarts.
Also, I'm not quite sure which branch we'd want to merge this into, because its based on the hackathon inlists. Maybe we want to rebase the top commits onto main first?