Skip to content

Pgplot residuals#1027

Closed
matthiasfabry wants to merge 17 commits into
mainfrom
pgplot_residuals
Closed

Pgplot residuals#1027
matthiasfabry wants to merge 17 commits into
mainfrom
pgplot_residuals

Conversation

@matthiasfabry

Copy link
Copy Markdown
Contributor

Based on @mathren initial work of bringing some diagnostic residual plots.

I had to refactor quite a lot to allow for our typical user controls.

I still need to do a few things, such as fix file printing, and possible allow for restarts.

Also, I'm not quite sure which branch we'd want to merge this into, because its based on the hackathon inlists. Maybe we want to rebase the top commits onto main first?

@mathren

mathren commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Thanks @matthiasfabry! Is there a strong dependence on the inlist parameters? I'd expect only the use_other_pgstar_plot=.true. to matter, so inlists shouldn't really matter for which branch to merge this on...

@matthiasfabry

matthiasfabry commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

I'm not sure what you mean?
I meant that this PR shouldn't be merging the hackathon massive star test cases into main.

@mathren

mathren commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

ok, sorry, I misunderstood. Indeed, I would maybe base this on main rather than the hackathon branch, and make it independent of the hackathon branch completely since nothing of the hackathon is necessary for these pgplots?

@mathren mathren self-requested a review June 10, 2026 20:22
@matthiasfabry

Copy link
Copy Markdown
Contributor Author

That's right, I'll see if can do the rebasing.

@rhdtownsend I cannot get saving to files to work because apparently, in the PNG device driver, pgimag will always use a fixed color palette. LLMs suggest updating the pgplot libs that come with the SDK. Is this possible?

@matthiasfabry

Copy link
Copy Markdown
Contributor Author

I cherry-picked the relevant commits on top of main; making a new PR:

@matthiasfabry

Copy link
Copy Markdown
Contributor Author

closing to other PR with cherry picked commits #1028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants