[vhdl] Fix incorrect latency of 64-bit cmpf#1000
Open
zero9178 wants to merge 3 commits into
Open
Conversation
The components.json file denoted cmpf to have a latency of 1. Similarily, the unit generator for `cmpf` always assumed a 0 cycle implementation. While this is the case for 32-bit, this is incorrect for FloPoCo on 64-bit (Line 3940 in `flopoco_ip_cores.vhd`): ``` -------------------------------------------------------------------------------- -- FPComparator_64bit -- (FPComparator_11_52_F500_uid2) -- VHDL generated for Kintex7 @ 500MHz -- This operator is part of the Infinite Virtual Library FloPoCoLib -- All rights reserved -- Authors: Florent de Dinechin (2021) -------------------------------------------------------------------------------- -- Pipeline depth: 1 cycles -- Clock period (ns): 2 -- Target frequency (MHz): 500 -- Input signals: X Y -- Output signals: unordered XltY XeqY XgtY XleY XgeY ``` This PR therefore fixes the issue by just correcting the components.json entry and the unit-generator for the non-0 latency case. Fixes #860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The components.json file previously denoted cmpf to have a latency of 0 which the unit generator for
cmpfalso hardcoded.While this is the case for 32-bit, this is incorrect for FloPoCo on 64-bit (Line 3940 in
flopoco_ip_cores.vhd):Worse than that, the
unorderedandXeqYhave a latency of 0 while the other flags have a latency of 1, meaning it is inconsistent dependeing on the predicate ofcmpf.We cannot currently model different predicates having different latencies in the
components.json.This PR therefore fixes the issue by just correcting the components.json entry and the unit-generator for the non-0 latency case, and adding an extra cycle of latency for
unorderedandXeqYto have a consistent latency regardless of predicate.Fixes #860
Fixes #999
Fixes #949
Fixes #1003