Avoid clearing region_highlight on zsh 5.9+ when zsh-syntax-highlighting is absent#178
Open
Hessamshar wants to merge 1 commit into
Open
Avoid clearing region_highlight on zsh 5.9+ when zsh-syntax-highlighting is absent#178Hessamshar wants to merge 1 commit into
Hessamshar wants to merge 1 commit into
Conversation
Hessamshar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
zsh-syntax-highlightingis not loaded, the plugin defines a fallback_zsh_highlightthat clearsregion_highlight=()on every printable keystroke. This destroys highlights set by other plugins, most notablyzsh-autosuggestions, whose suggestion text loses its styling after the second character typed.The fallback exists to clean up stale search highlights after a substring search ends. When
zsh-syntax-highlightingis present, it handles this naturally by rebuildingregion_highlighton every keystroke. The fallback emulates that behavior when it's absent, but it does so by wiping the entire array, which is overly aggressive and causes collateral damage to other plugins.