-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add sentry #2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stage
Are you sure you want to change the base?
feat: add sentry #2516
Changes from all commits
f9c2aaa
65fc732
e77bd3d
35e96d8
8c1d005
392a161
2383862
a018c07
c8b6c70
17e5b78
0e07e4d
6dd0ad1
2ab682a
f53ae9c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,4 +8,5 @@ TEMPLATE_URL=https://templating.api.zesty.io/ | |
| ALGOLIA_APPID= | ||
| ALGOLIA_APIKEY= | ||
| ALGOLIA_INDEX= | ||
| SENTRY_AUTH_TOKEN= | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,4 +1,4 @@ | ||||||||||||
| FROM node:18.18.2-alpine3.17 | ||||||||||||
| FROM node:18.20.4-alpine3.20 | ||||||||||||
|
finnar-bin marked this conversation as resolved.
|
||||||||||||
|
|
||||||||||||
| WORKDIR /usr/src/app | ||||||||||||
|
|
||||||||||||
|
|
@@ -14,6 +14,9 @@ ENV HOST=0.0.0.0 | |||||||||||
| ENV PORT=8080 | ||||||||||||
| ENV NEXT_TELEMETRY_DISABLED=1 | ||||||||||||
|
|
||||||||||||
| ARG SENTRY_AUTH_TOKEN | ||||||||||||
| ENV SENTRY_AUTH_TOKEN=$SENTRY_AUTH_TOKEN | ||||||||||||
|
Comment on lines
+17
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Secret persists in the runtime image.
The token only needs to exist for the
Suggested change
( Lower-effort alternative if you'd rather not touch the cloudbuild files: ARG SENTRY_AUTH_TOKEN
RUN SENTRY_AUTH_TOKEN=$SENTRY_AUTH_TOKEN npm run buildThis keeps the token scoped to that single RUN, so it isn't baked into the image config. |
||||||||||||
|
|
||||||||||||
| RUN npm run build | ||||||||||||
|
|
||||||||||||
| CMD [ "npm", "start" ] | ||||||||||||
Uh oh!
There was an error while loading. Please reload this page.