fix: allow users to exit out of create instance#2512
Conversation
Review summaryScope is small (one file, ~10 lines) and the goal is right, but the new control flow has a bug. Blocker — Minor
Otherwise nothing concerning from a security or performance perspective — no new data flows, no new network calls, just navigation logic. |
Review summarySmall, well-scoped fix that addresses #2511 — appreciated the focus. The change correctly restructures Main concern (inline): Minor observations (non-blocking):
Nothing else blocking from a code-quality, security, or performance standpoint. |
| sliderRef.current.swiper.slidePrev(); | ||
| }, [currentStep]); | ||
|
|
||
| router.back(); |
There was a problem hiding this comment.
router.back() is a no-op when there's no in-app history — e.g., if the user lands on /start directly via a shared link, email/marketing campaign, or new tab. In that case clicking the back chevron does nothing and the user is stuck on step 1 with no way to "exit".
Consider falling back to a known route when there's no history:
if (window.history.length > 1) {
router.back();
} else {
router.push('/');
}Same caveat applies if the previous entry was external (e.g., Google) — router.back() will navigate the user off the site entirely, which may or may not be the intended "exit" behavior.
|
Reviewed the change — small, focused, and matches the PR's goal of letting users exit the create-instance flow from step 1. Code quality: Implementation is clean. The early-return pattern reads well, the Bugs / UX: Flagged one edge case inline — Security: No concerns. No new inputs, no auth changes, no external calls. Performance: Negligible — adds |
Description
Allow users to exit out of the create instance flow
Fixes #2511
Type of change
Please delete options that are not relevant.
Screenshots / Screen recording
Screencast_20251010_074001.webm