fix: move zoxide/fnm after oh-my-posh so prompt hook survives - #1
Open
jpcallanta wants to merge 1 commit into
Open
fix: move zoxide/fnm after oh-my-posh so prompt hook survives#1jpcallanta wants to merge 1 commit into
jpcallanta wants to merge 1 commit into
Conversation
zoxide wraps prompt to run __zoxide_hook on every cd, but oh-my-posh replaces prompt outright without chaining the old one. When zoxide was initialized first its wrapper got overwritten — z still worked via manual query but never learned new dirs. Moved zoxide (and fnm, same hook) behind oh-my-posh so they wrap the final prompt, and added a regression test that checks file ordering and simulates the hook to keep this from regressing.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zoxide init powershellwrapspromptto run__zoxide_hookon everycdso the DB learns new dirs.oh-my-posh init pwshreplacespromptoutright (saves old, never calls it).When zoxide was initialized before oh-my-posh, its wrapper got silently overwritten —
z/zistill worked viazoxide querybut never auto-learned fromcd. You had tozoxide addmanually.Fix
Moved
zoxide(andfnm, same hook pattern) to after the oh-my-posh block so they wrap the final prompt. No logic changed, just ordering — nowprompt=oh-my-posh→zoxide→fnm.Test
Added
tests/Unit/ProfileOrdering.Tests.ps1— static file-order checks (zoxide/fnm must be afteroh-my-posh init pwsh) + a tiny simulation of the prompt wrapping to document the bug. Would have failed before the fix.