Skip to content

feat: Add basic UI, search implimentation#12755

Merged
mr-cheffy merged 2 commits into
zen-browser:libraryfrom
JustAdumbPrsn:library
Mar 31, 2026
Merged

feat: Add basic UI, search implimentation#12755
mr-cheffy merged 2 commits into
zen-browser:libraryfrom
JustAdumbPrsn:library

Conversation

@JustAdumbPrsn

@JustAdumbPrsn JustAdumbPrsn commented Mar 12, 2026

Copy link
Copy Markdown

Extends #12655

  • Added library-item along with styling
  • Search works properly and sorted by date.
  • Added separator which shows Today, Yesterday, then previous days of week, then full date, i.e, 13 March 2026
  • Search bar currently also has a Filter button but would probably be changed to "Sort" or "View" button like native firefox.

Note:

  • Styling may need more attention to use more variables which zen tabs does.
  • The history items do not currently have the recently closed tabs section, button to clear history, and glance button for each item to open that item as glance.
  • The downloaded items do not currently show the download progress ring while it does show active download exactly how firefox natively does.

@dosubot dosubot Bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Feature labels Mar 12, 2026
library-downloads-search-placeholder = Search Downloads…

library-history-today = Today
library-history-yesterday = Yesterday

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use something like:

new Intl.RelativeTimeFormat(undefined, {
          numeric: "auto",
        }).format(daysUntil, "day")

instead of hard coding it

library-history-section-title = History
library-history-section-title = History

library-search-placeholder = Search…

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can now just use

library-search-placeholder =
	.placeholder = Search…

Comment thread src/zen/library/ZenLibrarySections.mjs Outdated
Comment thread src/zen/library/ZenLibrarySections.mjs Outdated
@JustAdumbPrsn

Copy link
Copy Markdown
Author

thanks, on it

@mr-cheffy mr-cheffy marked this pull request as draft March 16, 2026 12:07
Signed-off-by: mr. m <91018726+mr-cheffy@users.noreply.github.com>
@mr-cheffy mr-cheffy marked this pull request as ready for review March 31, 2026 20:05
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 31, 2026
@mr-cheffy mr-cheffy self-requested a review March 31, 2026 20:05
@mr-cheffy mr-cheffy merged commit a217cac into zen-browser:library Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants