Rename Math_ScaledStepToS to rotation related name#2770
Open
djevangelia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is only used with rotations (I didn't examine unnamed variables) and can handle the boundary between max and min values of the signed rotation integers.
My suggestion would be
Math_RotationStepToSbecause it matches the otherMath_(Something)StepToS/F.Example using
Math_RotationStepToSvsMath_StepToSwith same arguments, the regular one cannot cross the boundary.https://github.com/user-attachments/assets/7f0b1df6-3c10-4fd7-b685-676b55904c49