Skip to content

Fix adding breakpoint/bookmark via gutter context menu using the wrong row#59269

Open
guopenghui wants to merge 1 commit into
zed-industries:mainfrom
guopenghui:fix-gutter-context-menu
Open

Fix adding breakpoint/bookmark via gutter context menu using the wrong row#59269
guopenghui wants to merge 1 commit into
zed-industries:mainfrom
guopenghui:fix-gutter-context-menu

Conversation

@guopenghui

@guopenghui guopenghui commented Jun 13, 2026

Copy link
Copy Markdown

Objective

Fixes #59265

Solution

Use display_point_to_anchor to properly convert DisplayRow to Anchor, instead of manually constructing Point directly as done currently.

Testing

  • Tested manually, see video in issue
  • Tested on windows

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Showcase

Click to view showcase

My super cool demos here


Release Notes:

  • Fixed the issue where right-clicking to add breakpoints or bookmarks in multibuffer would place them on the wrong lines.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 13, 2026
@zed-community-bot zed-community-bot Bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Jun 13, 2026
@maxdeviant maxdeviant changed the title Fix addding breakpoint/bookmark by guttter context menu gets wrong row Fix adding breakpoint/bookmark via gutter context menu using the wrong row Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gutter context menu get wrong row in multibuffer

1 participant