gpui_macos: Warn when falling back to NoopTextSystem - #59247
Merged
ChristopherBiscardi merged 1 commit intoJun 15, 2026
Conversation
Without the "font-kit" feature, MacPlatform silently substitutes gpui::NoopTextSystem, which accepts fonts and resolves font ids but rasterizes every glyph to an empty bitmap. The misconfiguration only surfaces as invisibly blank text in windowed apps, which is expensive to trace back to a missing cargo feature, so log a warning at startup. Skip the warning in headless mode, where no text is expected to render and the fallback is a reasonable configuration.
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
first contribution
ChristopherBiscardi
approved these changes
Jun 15, 2026
ChristopherBiscardi
enabled auto-merge
June 15, 2026 03:39
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This was referenced Jul 10, 2026
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…59247) # Objective Without the `font-kit` feature, `MacPlatform` silently substitutes `gpui::NoopTextSystem`, which accepts fonts and resolves font ids but rasterizes every glyph to an empty bitmap. I hit this with the `component_preview` example zed-industries#59241. ## Solution Log a warning at startup in `MacPlatform::new()` when falling back to `NoopTextSystem`. Skipped in headless mode, where no text is expected to render and the fallback is a reasonable configuration. ## Testing Checked as part of zed-industries#59241 ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) ## Showcase It just render as like without any error: <img width="1312" height="945" alt="cp_pr1_before" src="https://github.com/user-attachments/assets/f5faf3c0-9523-4c5f-9756-e65cbaf3456f" /> --- Release Notes: - N/A or Added/Fixed/Improved ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Without the
font-kitfeature,MacPlatformsilently substitutesgpui::NoopTextSystem, which accepts fonts and resolves font ids but rasterizes every glyph to an empty bitmap.I hit this with the
component_previewexample #59241.Solution
Log a warning at startup in
MacPlatform::new()when falling back toNoopTextSystem. Skipped in headless mode, where no text is expected to render and the fallback is a reasonable configuration.Testing
Checked as part of #59241
Self-Review Checklist:
Showcase
It just render as like without any error:
Release Notes: