Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Tests

on: [pull_request]
on: [pull_request, workflow_dispatch]

jobs:

Expand Down
6 changes: 6 additions & 0 deletions serde/de.py
Original file line number Diff line number Diff line change
Expand Up @@ -1484,6 +1484,12 @@ def render_from_dict(
)
serde_scope = getattr(cls, SERDE_SCOPE)
all_fields = defields(cls)
force_kw = False
for field in all_fields:
if not renderable(field):
force_kw = True
if force_kw:
field.kw_only = True
fields = list(filter(renderable, all_fields))
if serde_scope.transparent:
field = dataclasses.replace(fields[0], alias=[], rename="__serde_transparent__", case=None)
Expand Down
18 changes: 18 additions & 0 deletions tests/test_basics.py
Original file line number Diff line number Diff line change
Expand Up @@ -625,6 +625,24 @@ class Foo:
assert ff.a == 2


def test_skip() -> None:
# Note that skipped field is not the last one
@serde.serde
class Foo:
comments: list[str] = serde.field(default_factory=list, skip=True)
name: str = ""

f = Foo(["foo"], "bar")

# Serialization should work
assert serde.to_dict(f) == {"name": "bar"}

# Deserialization should work, using default for skipped field
restored = serde.from_dict(Foo, {"name": "bar"})
assert restored.name == "bar"
assert restored.comments == []


@pytest.mark.parametrize(
"se,de",
(format_dict + format_json + format_msgpack + format_yaml + format_toml + format_pickle),
Expand Down
Loading