fix(istio): gateway-prodのgroups認可を復旧 - #505
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
kensan.app.yu-min3.comでoauth2-proxy認証後にGatewayのgroup ALLOWへ進めずAccess deniedになる回帰を修正します。Before / After
Authorizationとして転送request.auth.claims[groups]を生成できずdenyplatform-adminclaimを検証可能根本原因
PR #499でBackstage application tokenを保護するため、共有ext_authz providerの
headersToUpstreamOnAllowからauthorizationを削除しました。しかし同じproviderを使うgateway-prodは、oauth2-proxyが返すKeycloak tokenをRequestAuthenticationで検証し、AuthorizationPolicyのgroups判定に使用しています。BackstageはPR #503でnative OIDCへ移行しCUSTOM policy対象外になったため、Bearer転送を復旧してもBackstage tokenは上書きされません。Argo CDとGrafanaも同様にCUSTOM対象外です。
検証
request.auth.claims[groups]を要求することを確認git diff --check壊れうるもの / 戻し方
共有oauth2-proxy対象のhostへKeycloak Bearerが再び渡ります。native auth appsは対象外です。問題時は本PRをrevertします。