feat(ros2): port #9787 ego status/info stream to ue5-dev - #15
Closed
youtalk wants to merge 5 commits into
Closed
Conversation
…arla-simulator#9786 Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
…arla-simulator#9787 (TF tree excluded) Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
… middleware creation succeeds Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Without CONFIGURE_DEPENDS, CMake globs the test/common, test/server, and test/client source directories only once at configure time. A stale build cache can then silently omit a newly added test file while gtest still exits 0 with a lower test count, as previously happened with test_type_hash.cpp until someone reconfigured. Adding CONFIGURE_DEPENDS re-runs the glob whenever the directory contents change. Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
CarlaOdometryPublisher, CarlaEgoVehicleStatusPublisher, CarlaEgoVehicleInfoPublisher, and CarlaMapPublisher logged a failed DDS writer creation at log_warning, while every other publisher (CarlaClockPublisher, CarlaPointCloudPublisher, CarlaCameraPublisher) logs the identical condition at log_error. A nullptr DDS writer is a silent-failure risk, so it should be as loud as its siblings. Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
youtalk
force-pushed
the
autoware/1-port-9786
branch
from
July 24, 2026 02:56
9afb44c to
37830af
Compare
Owner
Author
|
Folded into #14 (the ego status/info/odometry publishers and their fixups are now one squashed commit there); the maintainer tool Util/ros2/compute_type_hash.sh was dropped from the upstream-bound diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ego vehicle status/info and odometry publishers ported from the open ue4-dev draft carla-simulator#9787 (TF tree excluded). Carries three follow-up fixes: ego publisher constructors defined in Ros2Native so middleware creation succeeds, test-source globbing with CONFIGURE_DEPENDS, and publisher Init failures logged at error severity. Stack PR 2/9.