feat: add extractor classes for reflection#24
Open
owenvoke wants to merge 1 commit into
Open
Conversation
owenvoke
force-pushed
the
feature/extractor-classes
branch
from
February 27, 2026 15:16
dc64ada to
26abece
Compare
owenvoke
commented
Feb 27, 2026
Comment on lines
+31
to
+34
| $comment = $reflection->getDocComment(); | ||
| $unpadded = PhpDoc::unpad($comment); | ||
|
|
||
| return PhpDoc::unwrap($unpadded); |
Member
Author
There was a problem hiding this comment.
Do we want to fallback to the PhpDoc comments? 👀
owenvoke
force-pushed
the
feature/extractor-classes
branch
2 times, most recently
from
February 27, 2026 15:35
337cc94 to
10b43f1
Compare
owenvoke
force-pushed
the
feature/extractor-classes
branch
from
February 27, 2026 15:53
10b43f1 to
269c224
Compare
owenvoke
force-pushed
the
feature/extractor-classes
branch
from
February 27, 2026 16:06
269c224 to
c498f3f
Compare
owenvoke
force-pushed
the
feature/extractor-classes
branch
from
February 27, 2026 16:07
c498f3f to
fb1cc4b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves logic to 3 "extractor" classes so that it can be reused if needed.