Skip to content

Enable Dangermattic strings guardrail#22991

Merged
iangmaia merged 1 commit into
trunkfrom
mokagio/update-dangermattic-1-3
Jun 17, 2026
Merged

Enable Dangermattic strings guardrail#22991
iangmaia merged 1 commit into
trunkfrom
mokagio/update-dangermattic-1-3

Conversation

@mokagio

@mokagio mokagio commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates danger-dangermattic to 1.3.0 and enables its Android strings guardrail.

@mokagio mokagio self-assigned this Jun 17, 2026
@wpmobilebot

wpmobilebot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr22991-dc8c5dc
Build Number1496
Application IDcom.jetpack.android.prealpha
Commitdc8c5dc
Installation URL7em7k9h05vb00
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

wpmobilebot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr22991-dc8c5dc
Build Number1496
Application IDorg.wordpress.android.prealpha
Commitdc8c5dc
Installation URL673chf3pcuv8o
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio marked this pull request as ready for review June 17, 2026 00:34
@mokagio mokagio requested a review from a team as a code owner June 17, 2026 00:34
Copilot AI reviewed Jun 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repo’s Danger setup to use danger-dangermattic v1.3.x and turns on its Android strings “existing strings must not be modified” guardrail (with an escape hatch label).

Changes:

  • Bump danger-dangermattic from ~> 1.2 to ~> 1.3 (and update the lockfile accordingly).
  • Enable android_strings_checker.check_existing_strings_not_modified in Dangerfile, skipped when the PR has the Allow String Modifications label.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
Gemfile.lock Locks danger-dangermattic to 1.3.0 and updates the danger dependency to match.
Gemfile Updates the Bundler dependency constraint to danger-dangermattic ~> 1.3.
Dangerfile Adds the Android strings guardrail check, with a label-based opt-out.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mokagio mokagio added this to the 27.0 milestone Jun 17, 2026
@oguzkocer

oguzkocer commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

GitHub failed on my end when I approved an hour ago, and I didn't realize it went through and ended up approving again now. Sorry about that!

@mokagio @codex @iangmaia
Enable Dangermattic strings guardrail
dc8c5dc 
Dangermattic 1.3.0 includes the Android strings API needed to flag in-place edits to existing translatable strings.
Wire it into Danger while keeping release-process PRs skipped and allowing the explicit bypass label for intentional edits.

---

Generated with the help of Codex, https://openai.com/codex

Co-Authored-By: Codex GPT-5 <noreply@openai.com>
@iangmaia iangmaia force-pushed the mokagio/update-dangermattic-1-3 branch from f4761e5 to dc8c5dc Compare June 17, 2026 19:17
@iangmaia iangmaia enabled auto-merge (squash) June 17, 2026 19:17
@iangmaia iangmaia merged commit c376c3e into trunk Jun 17, 2026
19 of 22 checks passed
@iangmaia iangmaia deleted the mokagio/update-dangermattic-1-3 branch June 17, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@oguzkocer oguzkocer oguzkocer approved these changes

@iangmaia iangmaia iangmaia approved these changes

@jkmassel jkmassel Awaiting requested review from jkmassel

Assignees

@mokagio mokagio

Labels

Tooling

Projects

None yet

Milestone

27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mokagio @wpmobilebot @oguzkocer @iangmaia