Fix NPE in Site Settings GBKit toggle refresh with null site

[adalpari]

Description

Fixes a crash in Site Settings (Sentry issue, com.jetpack.android@26.8-rc-5+1493).

SiteSettingsProviderImpl.isBlockEditorDefault(site: SiteModel) declares a non-null Kotlin site parameter. The refresh of the GutenbergKit toggle is reached from the async onSettingsUpdated() callback (SiteSettingsInterface → Handler), which only guards with isAdded(). When mSite is null at that point, Java passes null into the non-null param and the compiler-generated Intrinsics.checkNotNullParameter check throws an NPE ("Attempt to invoke … getClass() on a null object reference").

This adds an mSite == null early-return guard to refreshGutenbergKitToggleAvailability(), matching the mSite null-guard pattern already used elsewhere in the fragment.

-        if (mGutenbergKitPref == null) return;
+        if (mGutenbergKitPref == null || mSite == null) return;

Testing instructions

Open Site Settings:

1. Open the app and navigate to My Site → Settings for a site.
2. Toggle Use block editor as default for new posts on/off.

• Verify the GutenbergKit toggle availability/summary refreshes without crashing.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr22953-f3c5f66
	Build Number	1493
	Application ID	com.jetpack.android.prealpha
	Commit	f3c5f66
	Installation URL	57k6qdctt0h7g

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr22953-f3c5f66
	Build Number	1493
	Application ID	org.wordpress.android.prealpha
	Commit	f3c5f66
	Installation URL	7stm2uch8p1tg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

[nbradbury]

@adalpari Claude suggested this as a follow-up but mentioning it here in case you'd rather implement it now:

ApplicationPasswordsFetchResponse (used by the WPApi client's fetch and introspect paths, WPApiApplicationPasswordsRestClient.kt:81 and :146) still declares uuid and name non-null, so the same latent Gson NPE exists there — it.uuid at line 89/156 would throw if the server ever omits the field. Same for any other Gson-backed data classes in this package. Since this PR is a targeted RC crash fix, leaving that to a trunk follow-up is reasonable, but it's worth filing.

[nbradbury]

@adalpari I'll approve this to unblock it, up to you whether to address my comment before merging

[adalpari]

@adalpari Claude suggested this as a follow-up but mentioning it here in case you'd rather implement it now:

ApplicationPasswordsFetchResponse (used by the WPApi client's fetch and introspect paths, WPApiApplicationPasswordsRestClient.kt:81 and :146) still declares uuid and name non-null, so the same latent Gson NPE exists there — it.uuid at line 89/156 would throw if the server ever omits the field. Same for any other Gson-backed data classes in this package. Since this PR is a targeted RC crash fix, leaving that to a trunk follow-up is reasonable, but it's worth filing.

Thank you for flagging it. Since it's a broader change and this PR is targeting a specific crash, I'm openign a new PR with the extra fix: #22968

[adalpari]

@adalpari Claude suggested this as a follow-up but mentioning it here in case you'd rather implement it now:

ApplicationPasswordsFetchResponse (used by the WPApi client's fetch and introspect paths, WPApiApplicationPasswordsRestClient.kt:81 and :146) still declares uuid and name non-null, so the same latent Gson NPE exists there — it.uuid at line 89/156 would throw if the server ever omits the field. Same for any other Gson-backed data classes in this package. Since this PR is a targeted RC crash fix, leaving that to a trunk follow-up is reasonable, but it's worth filing.

Wait, I'm confused. Does this comment belong to this other PR? Otherwise, the other opened PR is already fixing the problem 😅