Skip to content

retry: Consider http2 :disconnected and :read_only as transient #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeltaEvo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

retry: Consider http2 :disconnected and :read_only as transient #466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/req/steps.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2053,7 +2053,7 @@ defmodule Req.Steps do

* `Req.TransportError` with `reason: :timeout | :econnrefused | :closed`

* `Req.HTTPError` with `protocol: :http2, reason: :unprocessed`
* `Req.HTTPError` with `protocol: :http2, reason: :unprocessed | :disconnected | :read_only`

* `:transient` - same as `:safe_transient` except retries all HTTP methods (POST, DELETE, etc.)

Expand Down Expand Up @@ -2176,6 +2176,16 @@ defmodule Req.Steps do
true
end

# See https://github.com/sneako/finch/issues/144
defp transient?(%Req.HTTPError{protocol: :http2, reason: :disconnected}) do
true
end

# See https://github.com/sneako/finch/issues/216
defp transient?(%Req.HTTPError{protocol: :http2, reason: :read_only}) do
true
end

defp transient?(%{__exception__: true}) do
false
end
Expand Down