Add RTL8201-based wESP32 rev7 Ethernet option#5667
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds support for WESP32 Rev 7 (RTL8201) by incrementing the Ethernet type count, adding a new WLED_ETH_WESP32_RTL8201 constant and ethernetBoards[] entry (RTL8201, GPIO16/17, ETH_CLOCK_GPIO0_IN), clarifies the existing WESP32 comment, and splits the settings UI option into Rev ≤6 and Rev 7+. ChangesWESP32 Rev 7 (RTL8201) Ethernet Board Support
Sequence Diagram(s)sequenceDiagram
participant Browser
participant Firmware
participant EthernetTable
participant PHY
Browser->>Firmware: submit Ethernet Type (WESP32 Rev 7)
Firmware->>EthernetTable: lookup WLED_ETH_WESP32_RTL8201 (id 16)
EthernetTable->>PHY: initialize RTL8201 with MDC=GPIO16 MDIO=GPIO17 CLOCK=GPIO0_IN
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)wled00/network.cppIn file included from wled00/network.cpp:1: ... [truncated 1076 characters] ... ns/clang/install/lib/clang/18/include" Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add a separate Ethernet board type for wESP32 rev7 and later boards, which use the RTL8201 PHY instead of the LAN8720 used by earlier revisions.
Add a separate Ethernet board type for wESP32 rev7 and later boards, which use the RTL8201 PHY instead of the LAN8720 used by earlier revisions.
Summary by CodeRabbit