Skip to content

remove unused batch indexing code#1406

Merged
bw4sz merged 1 commit into
weecology:mainfrom
jveitchmichaelis:remove-old-pred-indices
Jul 13, 2026
Merged

remove unused batch indexing code#1406
bw4sz merged 1 commit into
weecology:mainfrom
jveitchmichaelis:remove-old-pred-indices

Conversation

@jveitchmichaelis

@jveitchmichaelis jveitchmichaelis commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

There's a lot of code that is no longer used, as we have moved to a more robust way of tracking where image crops came from when predicting over multiple images. This PR removes that so there's less confusion, and adds a test to check that windows are properly preserved via metadata.

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.73%. Comparing base (d2851ec) to head (b36f8e0).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/deepforest/datasets/prediction.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   86.61%   86.73%   +0.11%     
==========================================
  Files          26       28       +2     
  Lines        3736     4063     +327     
==========================================
+ Hits         3236     3524     +288     
- Misses        500      539      +39     
Flag Coverage Δ
unittests 86.73% <83.33%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jveitchmichaelis jveitchmichaelis requested a review from bw4sz July 8, 2026 00:58
@jveitchmichaelis jveitchmichaelis marked this pull request as ready for review July 8, 2026 00:58
@jveitchmichaelis jveitchmichaelis force-pushed the remove-old-pred-indices branch from e1eb941 to ecb3b40 Compare July 8, 2026 01:02
@jveitchmichaelis jveitchmichaelis force-pushed the remove-old-pred-indices branch from ecb3b40 to b36f8e0 Compare July 8, 2026 01:04
@bw4sz bw4sz merged commit 016fb69 into weecology:main Jul 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants