chore: use plugin support#4791
Conversation
🦋 Changeset detectedLatest commit: aa9a4ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4791 +/- ##
==========================================
+ Coverage 93.30% 93.34% +0.04%
==========================================
Files 14 14
Lines 5466 5559 +93
Branches 793 814 +21
==========================================
+ Hits 5100 5189 +89
- Misses 364 367 +3
- Partials 2 3 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
I'm not sure if you want to support both dev-server 5 and 6 at the same time, with 6 being the one that has plugin support, or if you'd rather introduce this in a new major version for dev-server 6. |
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
I think it's preferable to support dev-server 6 so it's easy to switch between versions, rather than releasing a new major version and making it more difficult to upgrade.
|
|
||
| - name: Install webpack-dev-server ${{ matrix.dev-server-version }} | ||
| if: matrix.dev-server-version == '5' | ||
| run: npm install webpack-dev-server@${{ matrix.dev-server-version }} --no-save --ignore-scripts |
There was a problem hiding this comment.
can we use npm ci instead?
There was a problem hiding this comment.
Nope, there's no other way
|
|
||
| if (this.#needWatchStdin(compiler)) { | ||
| process.stdin.on("end", () => { | ||
| compiler.close(() => { |
There was a problem hiding this comment.
do we need to clean exit fscache here too? 🤔
There was a problem hiding this comment.
No, shouldn't compiler.close() already do that natively?
| expect(stderr).toContain("Invalid value 'Yukihira' for the '--server-type' option"); | ||
| expect(stderr).toContain("Expected: 'http | https | spdy | http2'"); | ||
| expect(stderr).toContain( | ||
| devServerVersion === "5" |
There was a problem hiding this comment.
id split these sinto two seperate statements (assertions) if(cond) expect
else expect
… webpack-cli/package.json
…n invalid-schema test
…ility and signal handling
…ased on devServer version
Summary
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI