fix(plugin-runtime): fix document CLI compatibility with ESM lib format#8692
Open
imhele wants to merge 1 commit into
Open
fix(plugin-runtime): fix document CLI compatibility with ESM lib format#8692imhele wants to merge 1 commit into
imhele wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 79d9795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 118 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
Thanks for contribute~ Can you add a Chinese version changeset ? |
imhele
force-pushed
the
fix/plugin-runtime-document-esm-imports
branch
from
980c9db to
79d9795
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The document plugin's CLI helpers (
requireFromStringandgenerateEntryCode) relied on CJS-only Node.js APIs that are unavailable or incorrect when the package is built and consumed as an ES module:module.parentinrequireFromString: In ESM context, the CommonJSmoduleglobal does not exist, so passingmodule.parentas the parent tonew Module.Module()throws aReferenceErrorat runtime.require.resolve('../')ingenerateEntryCode:createRequire().resolve('../')cannot resolve toindexfile in an ESM module context.Solution
Both helpers are now guarded by a
process.env.MODERN_LIB_FORMAT === 'esm'check so they use the appropriate API depending on the module format:requireFromString: passesundefinedas the parent module when in ESM mode, which is a safe no-op forModule.Moduleand avoids the CJSmodule.parentreference.generateEntryCode: usesimport.meta.resolve('../index.mjs')to resolve the runtime API path in ESM mode (the.mjsentry is already the correct target), falling back torequire.resolve('../')in CJS mode.Affected package
@modern-js/runtime(patch)Related Links
Checklist
pnpm run change.