fix(plugin-bff): preserve package manifest trailing newline#8671
Open
omarshibli wants to merge 1 commit into
Open
fix(plugin-bff): preserve package manifest trailing newline#8671omarshibli wants to merge 1 commit into
omarshibli wants to merge 1 commit into
Conversation
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
omarshibli
force-pushed
the
fix/bff-package-json-newline
branch
from
09ed1bd to
a643d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve a trailing newline when the BFF client generator rewrites
package.json.Also await the package manifest update so callers do not race the generated manifest write.
Problem
plugin-bffrewritespackage.jsonwithJSON.stringify(packageJson, null, 2)and no trailing newline. In repositories that normalize manifests during dependency install, this makes framework generation and package manager normalization fight each other.Changes
\nwhen writing the generated package manifest.setPackagefromclientGenerator.Validation
pnpm --filter @modern-js/plugin-bff testpnpm exec biome check packages/cli/plugin-bff/src/utils/clientGenerator.ts packages/cli/plugin-bff/tests/clientGenerator.test.ts