fix: add @better-captcha/vue to external and promote to runtime dependency#3455
Merged
lizheming merged 3 commits intoMar 1, 2026
Conversation
Co-authored-by: lizheming <424491+lizheming@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback on captcha flow migration
fix: add @better-captcha/vue to external and promote to runtime dependency
Mar 1, 2026
…to copilot/sub-pr-3442
lizheming
approved these changes
Mar 1, 2026
lizheming
merged commit d51f3ff
into
codex/refactor-@waline/client-to-use-better-captcha
1 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@better-captcha/vuewas imported at runtime inCaptcha.tsandCommentBox.vuebut omitted fromexternalin the slim/component rollup builds, causing it to be bundled intoslim.js/component.js. It was also only listed as adevDependency, inconsistent with its actual runtime usage.Changes
rollup.config.ts: Add@better-captcha/vuetoexternalin both slim and component build configs, consistent with howvue,@vueuse/core, and other runtime deps are treatedpackage.json: Promote@better-captcha/vuefromdevDependencies→dependenciespackages/server/src/middleware/dashboard.js: Fix XSS vulnerability —process.env.CAPTCHAwas embedded in an inline<script>withoutJSON.stringify(), unlike all other env vars on adjacent lines💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.