feat: support configuring a minimum number of requests#254
Closed
hanxiantao wants to merge 2 commits into
Closed
Conversation
Member
|
I don't like hidden tracking link, demand to review, and ping. In all cases, the approach doesn't seems right. |
Author
Thanks for your feedback. I've deleted the corresponding comments, kindly take another look. |
Member
|
I think my previous comment was clear:
Your implementation doesn't follow the global design, I will try to create a PR. |
Member
|
PTAL #256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration option to set minimum request threshold before circuit breaker takes failure statistics into effect.
Fixes #241
Related to traefik/traefik#10963