feat: add search box to filter settings items (#833)#840
Draft
zackycodes wants to merge 2 commits into
Draft
Conversation
Added a search input for settings with styling.
Collaborator
|
Thanks for the PR. I assume this is vibe coded though? And I can't seem to make it work, nothing happens when I type things in the search input. It's also not that well integrated visually (UI is too minimal, no light mode support) or to the project's current architecture (inline CSS where the rest of the project has dedicated .css files). |
Owner
|
TODO for @zackycodes:
We'll only consider merging this implementation when all these requirements are met! |
Owner
|
And of course type-checking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #833 by introducing a dynamic real-time search/filter input at the top of the settings panel. This allows users to quickly find specific configuration options (like "wallpaper", "clock", or "font") without manually scrolling through the extensive options list.
Changes Made
src/settings.html: Inserted a minimalist search input field at the top of the settings panel layout.src/scripts/settings.ts: Implemented client-side filtering logic withinsettingsInitEvent()that:.paramelements based on case-insensitive matches against user input..settings-titlesections when none of their nested parameters match the search query.Closes
Closes #833