Skip to content

feat: add search box to filter settings items (#833)#840

Draft
zackycodes wants to merge 2 commits into
victrme:masterfrom
zackycodes:master
Draft

feat: add search box to filter settings items (#833)#840
zackycodes wants to merge 2 commits into
victrme:masterfrom
zackycodes:master

Conversation

@zackycodes
Copy link
Copy Markdown

Description

Addresses #833 by introducing a dynamic real-time search/filter input at the top of the settings panel. This allows users to quickly find specific configuration options (like "wallpaper", "clock", or "font") without manually scrolling through the extensive options list.

Changes Made

  • src/settings.html: Inserted a minimalist search input field at the top of the settings panel layout.
  • src/scripts/settings.ts: Implemented client-side filtering logic within settingsInitEvent() that:
    • Dynamically shows/hides individual .param elements based on case-insensitive matches against user input.
    • Automatically hides empty .settings-title sections when none of their nested parameters match the search query.

Closes

Closes #833

@morceaudebois
Copy link
Copy Markdown
Collaborator

Thanks for the PR. I assume this is vibe coded though?

And I can't seem to make it work, nothing happens when I type things in the search input. It's also not that well integrated visually (UI is too minimal, no light mode support) or to the project's current architecture (inline CSS where the rest of the project has dedicated .css files).

@victrme
Copy link
Copy Markdown
Owner

victrme commented May 31, 2026

TODO for @zackycodes:

  • Handle settings in disabled widgets
  • Handle sub-options (analog clock > clock style)
  • Handle dark/light theme
  • Add translations to placeholder
  • Move styling to settings .css
  • Only show on "All settings"

We'll only consider merging this implementation when all these requirements are met!

@victrme
Copy link
Copy Markdown
Owner

victrme commented May 31, 2026

And of course type-checking deno check passing without errors.

@victrme victrme marked this pull request as draft May 31, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Search box for quickly searching for setting items

3 participants