Skip to content

fix: fix browser usage #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
altano wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: fix browser usage #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e113ac5
update vitest
altano Apr 7, 2026
fbba101
add browser tests
altano Apr 7, 2026
987ee63
fix satori running in browser
altano Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ jobs:
- run: pnpm install
- run: pnpm build
- run: pnpm test
- run: pnpm exec playwright install
- run: pnpm test:browser
- name: Maybe Release
if: matrix.os == 'ubuntu-latest' && matrix.node == 20 && github.event_name == 'push' && github.ref == 'refs/heads/main'
env:
Expand Down
16 changes: 11 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@
"build:default": "NODE_ENV=production tsup",
"build:standalone": "NODE_ENV=production SATORI_STANDALONE=1 tsup",
"test": "NODE_ENV=test vitest run",
"test:browser": "vitest run --config=vitest.browser.config.ts",
"test:browser:ui": "vitest --ui --config=vitest.browser.config.ts",
"test:ui": "NODE_ENV=test vitest --ui --coverage.enabled",
"test-type": "tsc -p tsconfig.json --noEmit && tsc -p playground/tsconfig.json --noEmit",
"dev:test": "NODE_ENV=test vitest --update",
Expand Down Expand Up @@ -98,14 +100,17 @@
"homepage": "https://github.com/vercel/satori#readme",
"devDependencies": {
"@resvg/resvg-js": "^2.1.0",
"@types/node": "^16",
"@testing-library/dom": "^10.4.1",
"@types/node": "^25.5.2",
"@types/opentype.js": "^1.3.3",
"@types/react": "^17.0.38",
"@typescript-eslint/eslint-plugin": "^5.40.0",
"@typescript-eslint/parser": "^5.40.0",
"@vitest/coverage-v8": "^0.32.0",
"@vitest/ui": "^0.32.0",
"@vitest/browser-playwright": "^4.1.2",
"@vitest/coverage-v8": "^4.1.2",
"@vitest/ui": "^4.1.2",
"concurrently": "^7.3.0",
"esbuild": "^0.28.0",
"esbuild-plugin-replace": "^1.2.0",
"eslint": "^8.25.0",
"eslint-plugin-react": "^7.31.10",
Expand All @@ -114,14 +119,15 @@
"jest-image-snapshot": "^6.1.0",
"lint-staged": "13.1.0",
"mitata": "^1.0.34",
"playwright": "^1.59.1",
"prettier": "^2.7.1",
"react": "^17.0.2",
"react": "18.2.0",
"sharp": "^0.34.3",
"tsup": "^7.1.0",
"turbo": "^1.6.3",
"twrnc": "^3.4.0",
"typescript": "^5",
"vitest": "^0.32.0"
"vitest": "^4.1.2"
},
"dependencies": {
"@shuding/opentype.js": "1.4.0-beta.0",
Expand Down
2 changes: 1 addition & 1 deletion patches/yoga-layout@3.2.1.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ index efd1554faeebc6d6d792878f0ec63e4122ff3d96..232f122ef8fb2ba1c43844f88114ba46
- return wrapAssembly(await loadYogaImpl());
+export async function loadYoga(wasmOptions) {
+ const { default: loadYogaImpl } =
+ process.env.SATORI_STANDALONE === '1'
+ typeof process !== 'undefined' && process.env.SATORI_STANDALONE === '1'
+ ? await import('../binaries/yoga-wasm-esm.js')
+ : await import('../binaries/yoga-wasm-base64-esm.js')
+
Expand Down
Loading
Loading