fix(admin-ui): Seed channel token before config fetch#4760
fix(admin-ui): Seed channel token before config fetch#4760g8rr5dg2p7-svg wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
All contributors have signed the CLA ✍️ ✅ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
893c356 to
247b29e
Compare
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
e37b371 to
73ff581
Compare
|
Quick review-ready status note for the bounty claim: this PR is still narrowly scoped to #2363, the CLA is signed, all visible checks are green, and CodeRabbit reported no actionable comments. The included coverage exercises the missing-token bootstrap path, preserves an existing stored token, and verifies unauthenticated config loading still falls back without blocking startup. Happy to adjust the approach if you would prefer the token seeding to live in a different Admin UI bootstrap layer. |
|
Friendly follow-up on the bounty claim: this PR is still green, CLA is signed, CodeRabbit reported no actionable comments, and the Vercel preview remains ready. Since the claim is still awaiting maintainer review, I wanted to surface it once more and ask whether you would prefer any narrower change, additional test case, or different placement for the channel-token seeding logic. |
/claim #2363
Summary
Why
External authentication can leave the Admin UI authenticated but without an
activeChannelTokenin local storage. Since the app waits forServerConfigServiceduring bootstrap, setting the channel token there ensures the initial Admin API requests include the channel token instead of requiring a page reload.Testing
npm run buildinpackages/commonPUPPETEER_EXECUTABLE_PATH="/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" npm run test -- --include src/lib/core/src/data/server-config.spec.tsFixes #2363
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.