You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for this @xmh1011 — the UX you proposed here (showing accepted files as Processing/Failed rows until the real document lands) is exactly what we want, and the i18n coverage was a nice touch.
We've decided to land this server-driven instead of client-side. Rather than a sessionStorage store with client-generated document ids, the new version derives the pending rows from the existing file_convert_retain operations (the server already stores the document_id and original filename in the operation), so the status survives reloads/tabs/devices and there's no client-side id generation to keep in sync.
Superseded by #2420 (which closes #2314). Closing this one — really appreciate the contribution and the clear write-up that made the follow-up easy. 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2314
Tests