Skip to content
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
e9fc30c
refactor: addressin audit
kupermind Oct 13, 2025
7254502
chore: correcting reverts
kupermind Oct 14, 2025
fba35ad
chore: adding events
kupermind Oct 14, 2025
6938534
doc: adding natspec
kupermind Oct 14, 2025
8f5fd78
doc: adding natspec
kupermind Oct 14, 2025
9b2afe0
doc: adding natspec
kupermind Oct 14, 2025
3320c8a
chore: workflow
kupermind Oct 14, 2025
fb30a03
test: forge compile
kupermind Oct 14, 2025
4ef2c82
doc: natspec
kupermind Oct 15, 2025
0bdb8eb
fix: liquidity calculation
kupermind Oct 15, 2025
77a5c5c
chore: comments
kupermind Oct 15, 2025
ffaa829
chore: comments
kupermind Oct 15, 2025
bd8a129
refactor and test: several bugs and more tests
kupermind Oct 16, 2025
705f815
chore: addressing stack too deep
kupermind Oct 16, 2025
c8fd1e0
test: adding more tests
kupermind Oct 16, 2025
db83f47
test: more precise testing
kupermind Oct 17, 2025
bbc6e40
test: fixing block number shift with updated forge logic
kupermind Oct 17, 2025
84fc4fa
test: fixing block number shift with updated forge logic
kupermind Oct 17, 2025
f9ea1e8
test: adding fork tests for base
kupermind Oct 17, 2025
237a184
refactor: balancer remove liquidity
kupermind Oct 17, 2025
17248bd
refactor: balancer remove liquidity
kupermind Oct 17, 2025
932a9ff
refactor: balancer remove liquidity
kupermind Oct 17, 2025
16efa2d
chore: linter
kupermind Oct 17, 2025
de7e0f7
fix: arrays by reference
kupermind Oct 20, 2025
630fc0f
refactor: proxy and calldata
kupermind Oct 20, 2025
9fb2732
chore: variable name change
kupermind Oct 20, 2025
c209137
chore: redundant allocation
kupermind Oct 20, 2025
7accd09
refactor and chore: neighborhood fix and memory to calldata
kupermind Oct 20, 2025
22d85a2
fix: out of intermediate ranges liquidity calculation
kupermind Oct 20, 2025
d261b01
chore: optimization runs not to exceed contract size
kupermind Oct 20, 2025
60ece28
chore: code formatting
kupermind Oct 20, 2025
92fa809
chore: formatting
kupermind Oct 20, 2025
7f835d8
chore: allocation when required
kupermind Oct 20, 2025
6d2f1ad
test: add more test cases
kupermind Oct 21, 2025
1c03b90
feat: Bridge2Burner contract
kupermind Oct 21, 2025
f21daa4
chore: formatting
kupermind Oct 21, 2025
61287ba
chore: comment
kupermind Oct 21, 2025
e7e41db
test: adding Bridge2Burner testing
kupermind Oct 22, 2025
b9ac293
feat: add Bridge2BurnerGnosis
kupermind Oct 22, 2025
8a814d0
test: add more tests
kupermind Oct 23, 2025
c861347
doc: internal9 audit
Oct 23, 2025
1a7df2b
Merge pull request #239 from valory-xyz/v1.4.1-internal-audit
kupermind Oct 23, 2025
0514120
refactor: addressing internal audit
kupermind Oct 23, 2025
eadd5a3
chore: min balance correction
kupermind Oct 23, 2025
04eddd0
refactor: making bridge burner functions lighter
kupermind Oct 23, 2025
c759343
chore: CI forge test
kupermind Oct 23, 2025
8ebe8ae
Merge pull request #240 from valory-xyz/bridge2burner_address_interna…
kupermind Oct 23, 2025
bafce33
chore: update packages
kupermind Oct 23, 2025
fa42bee
chore: migrating to new eslint
kupermind Oct 23, 2025
26712f2
chore: migrating to new eslint
kupermind Oct 23, 2025
bba8be1
chore: migrating to new eslint
kupermind Oct 23, 2025
1395666
Merge pull request #238 from valory-xyz/bridge2burner
kupermind Oct 24, 2025
d08d38a
Merge pull request #237 from valory-xyz/forge_formatting
kupermind Oct 24, 2025
ae72e00
Merge pull request #236 from valory-xyz/calldata_memory
kupermind Oct 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions audits/internal8/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ mapPoolAddressPositionIds[pool] = 0
-> ????
because impossible set mapPoolAddressPositionIds[pool] = new.
```
[]
[x] Fixed

#### High. Incorrect logic _increaseLiquidity
```
Expand Down Expand Up @@ -112,7 +112,7 @@ function _increaseLiquidity(
);
}
```
[]
[x] Fixed

### High. Issue check/logic/execution olasBurnRate in convertToV3
```
Expand All @@ -127,7 +127,7 @@ You must either prohibit the burning of all OLAS/transfer all non-OLAS or be sur
Not sure, designed for extreme cases:
olasBurnRate = or ~= MAX_BPS.
```
[]
[x] Fixed

### High. Unsafe value0InToken1
```
Expand All @@ -146,7 +146,7 @@ function value0InToken1(uint256 amount, uint160 sqrtP) internal pure returns (ui
return FullMath.mulDiv(tmp, sqrtP, FixedPoint96.Q96);
}
```
[]
[x] Fixed

### Medium/Notes. The problem is in the design (increaseLiquidity vs decreaseLiquidity)
```
Expand All @@ -155,7 +155,7 @@ function convertToV3
increaseLiquidity must be a separate symmetric function.
The workflow of mapPoolAddressPositionIds[v3Pool] (positionId) must be described separately and explicitly as critical issue of contract.
```
[]
[x] Noted, but if we need to convert more V2 tokens, this path must remain as positionId already exists

#### Medium/Low. Token like USDT as token1.
```
Expand All @@ -170,7 +170,7 @@ interface IUSDT {
function transfer(address, uint256) external;
}
```
[]
[x] Fixed

#### Medium?/Notes. Rewrite variable without usage
```
Expand All @@ -182,7 +182,7 @@ function _adjustTicksAndMintPosition()
(positionId, liquidity, amountsIn) =
_mintV3(tokens, amountsIn, amountsMin, optimizedTicks, feeTierOrTickSpacing, centerSqrtPriceX96);
```
[]
[x] Fixed

#### Medium. Double check code with utilization
```
Expand All @@ -206,7 +206,7 @@ function _adjustTicksAndMintPosition()
}

```
[]
[x] Fixed

#### Low?/Notes. Double check logic _manageUtilityAmounts
```
Expand Down Expand Up @@ -245,7 +245,7 @@ function _adjustTicksAndMintPosition()
2. _manageUtilityAmounts(tokens, MAX_BPS, false); => will take the remaining token1, but this will make two transfers instead of one.
In general, this will not lead to problems, but only because the remainder will be taken based on the balances.
```
[]
[x] Noted

### Low. Unnamed revert()
```
Expand All @@ -260,7 +260,7 @@ contracts/pol/LiquidityManagerOptimism.sol: revert();
contracts/pol/LiquidityManagerOptimism.sol: revert();
contracts/pol/NeighborhoodScanner.sol: revert();
```
[]
[x] Fixed

### Low. A lot missing NatSpec
```
Expand All @@ -284,21 +284,18 @@ The absence of events makes subgraph monitoring/using impossible
- changeRanges
- decreaseLiquidity
```
[]
[x] Fixed

### Low. Remove variable NEAR_STEPS = SAFETY_STEPS
```
// Steps near to tick boundaries
int24 internal constant NEAR_STEPS = SAFETY_STEPS;
```
[]
[x] Fixed

### Notes. decreaseLiquidity function burns olasBurnRate% of (fee + decreaseLiquidity)
```
It should be clear at the specification level that the burn rate applies to all "received" (from pool) olas, and not just to fee.
To avoid incorrect conclusions for DAO
```
[]



[x] Fixed
Loading
Loading