refactor: update withheld amount maintenance - #213
Merged
Conversation
77ph
previously approved these changes
Jun 23, 2025
refactor: account for withheld amount update flag
mariapiamo
previously approved these changes
Jun 23, 2025
kupermind
commented
Jun 24, 2025
Comment on lines
+404
to
+417
| /// @dev Updates withheld amount manually by the DAO in order to account for `processDataMaintenance()` amounts. | ||
| /// @notice The amount here must correspond to the exact withheldAmount minus the accumulation of all the previous | ||
| /// unique amounts deposited via `processDataMaintenance()` function execution. | ||
| /// @param amount Updated withheld amount. | ||
| function updateWithheldAmountMaintenance(uint256 amount) external { | ||
| // Check the contract ownership | ||
| if (msg.sender != owner) { | ||
| revert OwnerOnly(msg.sender, owner); | ||
| } | ||
|
|
||
| withheldAmount = amount; | ||
|
|
||
| emit WithheldAmountUpdated(amount); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Introducing function described in the WD.
doc: re-audit 1.3.3
chore: Addressing internal audit 2
refactor: addressing internal audit
77ph
approved these changes
Jun 27, 2025
mariapiamo
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TargetDispenserL2resolution.