Fix/KUSTOM-90 consecutive setklarnaorderid calls not clearing instance cache#9
Open
jooname wants to merge 2 commits into
Open
Conversation
…th different Magento versions
…ectly caching retrieved order/quote data to the instance and to replicate an issue where consecutive calls of setKlarnaOrderId with different values doesn't result in the data in the instance not getting reset. Applied clearing of instance cache data in WorkflowProvider when setKlarnaOrderId is called.
vaimohe
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains also changes from #8 since this branch was started from there: easier to run test automations when blockers for running the tests are solved as well.
Fixes an issue with
Model/WorkflowProviderwhere callingsetKlarnaOrderIdwith different order ids in same process doesn't result in the cached instances in the class to reset, resulting ingetMagentoOrderreturning the same instance even if different order id was passed. Now callingsetKlarnaOrderIdresets those cached instances, forcing them to be reloaded when for examplegetMagentoOrderis called again. This way the data returned by the getter methods in the class should be more accurate.Changes in the application code have been done in backwards compatible manner and require only patch version to be bumped for the next release.