xargs: do not panic on empty input in replace mode#736
Open
leeewee wants to merge 1 commit into
Open
Conversation
In replace mode (-I/-i/--replace) xargs runs the command once per input item, so with empty input it should run nothing. Instead the final builder was still executed and `CommandBuilder::execute` indexed `extra_args[0]`, which is empty for no input, panicking with index-out-of-bounds. Treat replace mode as implying --no-run-if-empty (as GNU does) so empty input runs nothing and exits 0.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
==========================================
+ Coverage 91.86% 91.87% +0.01%
==========================================
Files 35 35
Lines 7153 7152 -1
Branches 375 376 +1
==========================================
Hits 6571 6571
Misses 437 437
+ Partials 145 144 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #735
xargs -I {}(and-i,--replace) panicked on empty input:In replace mode
xargsruns the command once per input item, so with empty input it should run nothing. Instead the final builder was still executed andCommandBuilder::executeindexedextra_args[0], which is empty when no items were read.This treats replace mode as implying
--no-run-if-empty(as GNU does), so empty input runs nothing and exits 0:Non-empty replace input still runs per item, and non-replace /
-rbehavior is unchanged. Added a regression test (xargs_replace_empty_input).