fix(objectives): support depots with no location for hierarchical areas#11
Open
hutchinsp01 wants to merge 1 commit into
Open
fix(objectives): support depots with no location for hierarchical areas#11hutchinsp01 wants to merge 1 commit into
hutchinsp01 wants to merge 1 commit into
Conversation
1bc45e8 to
6cf2c8c
Compare
6cf2c8c to
6ad64f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We provide a start location of None if the technician doesn't have a depot set.
This is an issue as
technicallythe VRP doesn't support VehicleShiftStarts with no start location, though it happily accepts it, and generates schedules with no depot location.When using the
Hierarchical Areasobjective we run into an issue where it expects all locations to be valid, but we can incidentally include depots with no real location.This filters those out to fix this objective erroring out.