Skip to content

feat(Number Field): add startingValue prop for increment/decrement #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rikzwarthoff wants to merge 3 commits into
base: v2
Choose a base branch
from
Open

feat(Number Field): add startingValue prop for increment/decrement #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8944c5
feat(Number Field): add startingValue prop for increment/decrement
rik-thalex May 6, 2026
da1e58a
fix(Number Field): clamp startingValue input
rik-thalex May 6, 2026
aeec578
fix(Number Field): clamp startingValue input only
rik-thalex May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/core/src/NumberField/NumberField.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,22 @@ describe('numberField', () => {
expect(input.value).toBe('0')
})

it('should start at starting value on increment/decrement, when no value present', async () => {
const { input, increment, decrement } = setup({ step: 3, startingValue: 40 })
expect(input.value).toBe('')

await userEvent.click(increment)
expect(input.value).toBe('40')
await userEvent.click(increment)
expect(input.value).toBe('43')

await userEvent.clear(input)
await userEvent.click(decrement)
expect(input.value).toBe('40')
await userEvent.click(decrement)
expect(input.value).toBe('37')
})

it('should increase and decrease based on keyboard navigation on input', async () => {
const { input } = setup({ defaultValue: 0, min: 0, max: 10 })

Expand Down
6 changes: 4 additions & 2 deletions packages/core/src/NumberField/NumberFieldRoot.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export interface NumberFieldRootProps extends PrimitiveProps, FormFieldProps {
invertWheelChange?: boolean
/** Id of the element */
id?: string
/** The value at which increment/decrement starts at when no value is given. */
startingValue?: number
}

export type NumberFieldRootEmits = {
Expand Down Expand Up @@ -81,7 +83,7 @@ const props = withDefaults(defineProps<NumberFieldRootProps>(), {
focusOnChange: true,
})
const emits = defineEmits<NumberFieldRootEmits>()
const { disabled, readonly, disableWheelChange, invertWheelChange, min, max, step, stepSnapping, formatOptions, id, locale: propLocale } = toRefs(props)
const { disabled, readonly, disableWheelChange, invertWheelChange, min, max, step, stepSnapping, formatOptions, id, locale: propLocale, startingValue } = toRefs(props)

const modelValue = useVModel(props, 'modelValue', emits, {
defaultValue: props.defaultValue,
Expand Down Expand Up @@ -119,7 +121,7 @@ function handleChangingValue(type: 'increase' | 'decrease', multiplier = 1) {
return
const currentInputValue = numberParser.parse(inputEl.value?.value ?? '')
if (isNaN(currentInputValue)) {
modelValue.value = min.value ?? 0
modelValue.value = startingValue.value !== undefined ? clampInputValue(startingValue.value) : min.value ?? 0
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
else {
if (type === 'increase')
Expand Down