Feature/quiz inline feedback#1797
Open
Ankit-lab809 wants to merge 170 commits into
Open
Conversation
…on_notification_to_users
…s' of github.com:unicef/iogt into feature/registration_notification_to_users
…com/unicef/iogt into feature/add_upgrade_features
…com/unicef/iogt into feature/add_upgrade_features
…er_engagement_and_profile_management
Collaborator
sachin-mehta
left a comment
sachin-mehta
left a comment
There was a problem hiding this comment.
- Check date_of_birth, gender fields for existing users, if these are working fine or not.
- The migration for QuizAttempt creation: ensure no conflict with existing data or absent foreign keys.
- The PageVisit model may grow very large — consider if you need retention/archival strategy.
- The CSS sets .activity-table { width:150% } – Might overflow container; check on various devices/screen sizes.
- The CSS uses font-size: 0.9rem for buttons, line-height 1.2 – ensure readability and accessibility (WCAG).
- Inline styling is present, move to css and ensure existing elements /selectors are not affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.