feat: Add normalization for invalid multiselect values in Validable model#405
Open
arsen-vs wants to merge 2 commits into
Open
feat: Add normalization for invalid multiselect values in Validable model#405arsen-vs wants to merge 2 commits into
arsen-vs wants to merge 2 commits into
Conversation
…odel * Implemented a static method to normalize invalid values for fields that allow multiple selections. * Updated the validate_with_checker method to utilize the new normalization method, ensuring invalid multiselect values are preserved as lists. * Added a test to verify that invalid multiselect values are correctly handled and stored as lists.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #405 +/- ##
========================================
Coverage 96.93% 96.94%
========================================
Files 237 237
Lines 9798 9810 +12
Branches 1092 1096 +4
========================================
+ Hits 9498 9510 +12
Misses 143 143
Partials 157 157 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ct values * Introduced multiple test cases to validate the normalization of invalid values for fields that allow multiple selections. * Tests cover various input types including None, lists, tuples, sets, and scalars to ensure consistent behavior across different scenarios.
arsen-vs
requested review from
datamik,
domdinicola,
roma-valor and
vitali-yanushchyk-valor
roma-valor
approved these changes
Jun 5, 2026
vitali-yanushchyk-valor
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AB#319150