Skip to content

Feat/tech 9136 merge create and update flows#242

Open
Javiershenbc wants to merge 5 commits into
mainfrom
feat/TECH-9136-merge-create-and-update-flows
Open

Feat/tech 9136 merge create and update flows#242
Javiershenbc wants to merge 5 commits into
mainfrom
feat/TECH-9136-merge-create-and-update-flows

Conversation

@Javiershenbc
Copy link
Copy Markdown
Collaborator

Adding frontend and backend support for merge of the create and update flows.

On the frontend this includes:

  • Country selection on file upload step.
  • Removal of upload mode selection.
  • Rework of the fuzzy logic modal to include a previous step of reviewing the impact of this upload.
  • Metadata country selection is disabled but still shown for user info

On backend:

  • API endpoint for sending the file to the backend alongside of country, dataset and column_to_schema_mapping
  • Query to Trino db table to get the country school ids based on iso3 code.
  • School Ids normalizing and comparing.
  • Result is in this form:
{
  "new_schools": 50,
  "schools_to_update": 300,
  "rows_with_school_id": 350,
  "missing_school_id_rows": 0,
  "unique_school_ids": 348,
  "duplicate_school_id_rows": 2
}
image image image

Javiershenbc and others added 5 commits June 2, 2026 11:04
Merge create and update flows.

Creation of the 2 step modal, having impact review on first step and fuzzy logic on 2nd step.  Impact review calls for api passing the data and expects the number of schools to be created and updated.

TODO: api endpoint checking trino and comparing the ids and passing back the correct number
Adding backend endpoint for upload update/create flow merge and unit tests (not e2e)
Adding automatic mode assignment based on number of schools updated/created: CREATE if 0 updates, UPDATE if 0 creates, MIXED if 0< on both

Have country on metadata as a disabled option
add duplicate checks and missing id checks
@Javiershenbc
Copy link
Copy Markdown
Collaborator Author

image Update with missing ids and duplicate ids

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant