Feature/tech 6338/download dq kit#240
Conversation
| buffer.seek(0) | ||
| return buffer | ||
|
|
||
| logger.info("Pre-built DQ Kit not found. Building on-demand.") |
There was a problem hiding this comment.
If the Dagster prebuilt dq kit is not found, it's just returning None and on uploads.py will break. I think there is not on-demand build or any fallback case
There was a problem hiding this comment.
@Javiershenbc for old pipelines on demand zip was not required as per the requirements, so let me know how we want to handle this, just hide the button?
There was a problem hiding this comment.
I would just hide the button in that case, so there is less confusion for the user. In case of future changes, we can manage this small change.
cc: @brianmusisi
| </Tabs> | ||
| </div> | ||
|
|
||
| {uploadData.dq_status === "COMPLETED" && ( |
There was a problem hiding this comment.
This should be only for school geolocation uploads. There should be no map for coverage or other uploads. Either we add a dataset = geolocation o more ideally if the backend can flag it as having or not a map so the frontend doesnt have to guess
|
|
||
| {mapUrl && !mapLoading && !mapError && ( | ||
| <iframe | ||
| src={mapUrl} |
There was a problem hiding this comment.
The map is rendered as active HTML outside the frontend bundle, so I’d treat iframe sandboxing as a small hardening improvement. Adding sandbox="allow-scripts" would allow the map JavaScript to run while keeping it isolated from the parent app context.
Javiershenbc
left a comment
Javiershenbc
left a comment
There was a problem hiding this comment.
Added some comments for improvements.
2 participants
What type of PR is this?
build: Commits that affect build components like build tool, dependencies, projectversion
chore: Miscellaneous commits (e.g. modifying.gitignore)ci: Commits are specialbuildcommits that affect the CI/CD pipelinedocs: Commits that affect documentation onlyfeat: Commits that add a new featurefix: Commits that fix a bugperf: Commits are specialrefactorcommits that improve performancerefactor: Commits that rewrite/restructure your code, however does not change anybehaviour
revert: Commits that revert another commit/PR, usually can be autogenerated onGitHub or using
git revertstyle: Commits are specialrefactorcommits that edit the code to comply with acode style, linter, or formatter
test: Commits that add missing tests or correcting existing testsSummary
What does this PR do
How to test
Link to Jira/Asana/Airtable task (if applicable)
placeholder
Wireframe screenshot/screencap (if applicable)
placeholder
Implementation screenshot/screencap (if applicable)
placeholder