feat: TestCases with 70% coverage#430
Open
bidhan-nagarro wants to merge 17 commits into
Open
Conversation
brianmusisi
requested changes
Mar 10, 2026
Collaborator
brianmusisi
left a comment
There was a problem hiding this comment.
@bidhan-nagarro, most of these tests are not actually testing any actual functionality. Everything is being mocked, and so we are not testing any actual functionality.
What we need to do test that when we perform transformations, the results we get are what we expect. For example, if we have duplicates, those should be picked up.
If we receive invlaid values, they are being handled. That's what these should do. I don't see this being done anywhere for any of the assets
c9f24f5 to
a98eb15
Compare
brianmusisi
approved these changes
Apr 24, 2026
Collaborator
brianmusisi
left a comment
There was a problem hiding this comment.
Fix merge conflicts and then should be fine. Do not merge, I will merge when I'm back
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
test: Commits that add missing tests or correcting existing testsSummary
What does this PR do
This PR adds unit test cases and tries 70% code coverage
how to test
Trigger the Test Suite locally (or on CI/CD):
dagsterdirectory (or the root if usingtask).task testcd dagster poetry run pytest --cov=src --cov-report=term-missingVerify All Tests Pass:
100% passesand zero failures.Verify Code Coverage:
pytest-covat the end of the test execution.TOTALcoverage percentage line at the very bottom should be over 70%, verifying that the new coverage requirements are met.