Complete rt-inconsistency check#784
Open
hauff wants to merge 1 commit into
Open
Conversation
Member
|
Could you rebase this PR, then I can take a look. |
- Implemented complete rt-Inconsistency pre-check
hauff
force-pushed
the
wip/mf/rtiPreCheck
branch
from
e839dfe to
1829bd8
Compare
Contributor
Author
@danieldietsch done. |
danieldietsch
requested changes
Jun 30, 2026
| ARCH="linux" | ||
| ARCHPATH="products/CLI-E4/linux/gtk/x86_64" | ||
| ADDS+=("adds/z3" "adds/cvc4nyu" "adds/cvc4" "adds/mathsat") | ||
| ADDS+=("adds/z3" "adds/cvc4nyu" "adds/cvc4" "adds/mathsat" "adds/mus_enumerator") |
Member
There was a problem hiding this comment.
Does mus_enumerator have a licence? You also need to add some info to our READMEs.
Member
There was a problem hiding this comment.
Is the name still meaningful?
| import de.uni_freiburg.informatik.ultimate.smtinterpol.muses.Translator; | ||
| import de.uni_freiburg.informatik.ultimate.smtinterpol.smtlib2.SMTInterpol; | ||
|
|
||
| public class CompleteRtInconsistencyCheck { |
Member
There was a problem hiding this comment.
This class would benefit from comments... E.g., I cannot tell what most of the fields of the CritPhase record are supposed to be.
| private final IUltimateServiceProvider mServices; | ||
| private final ILogger mLogger; | ||
| private final CompleteRtInconsistencyCheckMode mMode; | ||
| final Map<String, AnnotatedReq> mAnnotatedReqs; |
| } | ||
|
|
||
| public List<Entry<PatternType<?>, PhaseEventAutomata>[]> check() { | ||
| // TODO: Add option to filter groups and muses with size 1 |
Member
There was a problem hiding this comment.
Why, what would that do? Are you planning on doing that todo for this PR, or is this for the future?
| private final IIdentifierTranslator[] mIdentifierTranslators; | ||
| private final IReqSymbolTable mReqSymboltable; | ||
| private final Boogie2SMT mBoogieToSmt; | ||
| protected final Boogie2SMT mBoogieToSmt; |
| final List<Statement> stmtList = new ArrayList<>(); | ||
| final List<Entry<PatternType<?>, PhaseEventAutomata>[]> subsets = CrossProducts.subArrays( | ||
| consideredAutomata.toArray(new Entry[count]), actualCombinationNum, new Entry[actualCombinationNum]); | ||
| List<Entry<PatternType<?>, PhaseEventAutomata>[]> subsets = new ArrayList<>(); |
Member
There was a problem hiding this comment.
Dont initialize if you override
| if (mCompleteRtInconsistencyCheck) { | ||
| subsets = mRtInconcistencyConditionGenerator.doRtiPreCheck(mReqPeas, mCompleteRtInconsistencyCheckMode); | ||
| if (mCompleteRtInconsistencyCheckCandidateExtraction) { | ||
| return new ArrayList<>(); |
| private static final boolean DEF_COMPLETE_RT_INCONSISTENCY_CHECK = true; | ||
| private static final String DESC_COMPLETE_RT_INCONSISTENCY_CHECK = """ | ||
| This check allows for a fast and complete analysis for rt-inconsistency by reducing the number of \ | ||
| requirement combinations that need to be checked."""; |
Member
There was a problem hiding this comment.
You could point to some paper in the description.
| return results; | ||
| } | ||
|
|
||
| public static class SubsetSolver { |
Member
There was a problem hiding this comment.
Its weird to have that as public static class -- are you sure you need to expose both solvers and cannot hide them completely?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the existing rt-inconsistency analysis such that it uses a pre-computed candidate set.