feat: add purge option to snap uninstall dropdown (#2019)#2057
Open
gauravsaini wants to merge 1 commit into
Open
feat: add purge option to snap uninstall dropdown (#2019)#2057gauravsaini wants to merge 1 commit into
gauravsaini wants to merge 1 commit into
Conversation
Add an option to remove snaps with user data (--purge flag) via a dropdown menu on the Uninstall button. Changes: - Add removeWithPurge() method to SnapModel that passes purge: true to snapd - Add removePurge action to SnapAction enum - Convert single Uninstall button to dropdown with 'Uninstall' and 'Uninstall (remove data)' options - Add l10n strings for the purge action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
snap_model.dart: AddedremoveWithPurge()method that passespurge: trueto snapdsnap_action.dart: AddedremovePurgeaction variantmanage_app_actions.dart: Converted Uninstall button to dropdown with two options:app_en.arb: Added l10n strings for purge actionTesting
The dropdown menu shows two options when clicking the Uninstall button on the manage page. The "Uninstall (remove data)" option uses the snapd API's existing
purgeparameter.