fix: hide contributors section on network error (#2020)#2051
Open
gauravsaini wants to merge 1 commit into
Open
fix: hide contributors section on network error (#2020)#2051gauravsaini wants to merge 1 commit into
gauravsaini wants to merge 1 commit into
Conversation
When GitHub API is unreachable (e.g., SocketException), the raw error message was displayed in the UI. Now the contributors section is hidden gracefully when loading fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SizedBox.shrink()instead of raw exception text when contributors fail to loadChanges
packages/app_center/lib/about/about_page.dartto return an empty widget on error instead of displayingerror.toString()packages/app_center/test/about_page_test.dartTesting
The test verifies that when the contributors provider throws an error, the About page still renders correctly without showing the raw error message to the user.