admin api create/delete/disable/enable support tablename like ns:name#177
Open
xfan001 wants to merge 7 commits into
Open
admin api create/delete/disable/enable support tablename like ns:name#177xfan001 wants to merge 7 commits into
xfan001 wants to merge 7 commits into
Conversation
dethi
requested changes
Dec 10, 2021
dethi
left a comment
dethi
left a comment
Collaborator
There was a problem hiding this comment.
It would also make sense if the namespace was saved in the base struct (see hrpc/call.go). This would mean that the extraction happens in the various NewX(...) function and that we can add a Namespace() []byte function to the base struct (like we already have Table() []byte)
Comment on lines
+102
to
+107
| namespace := []byte("default") | ||
| table := ct.table | ||
| if i := bytes.Index(table, []byte(":")); i > -1 { | ||
| namespace = table[:i] | ||
| table = table[i+1:] | ||
| } |
Collaborator
There was a problem hiding this comment.
This block of code is identical everywhere, can you extract it to a function that returns the namespace and table name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create/delete/disable/enable action support set namespace