fix(security): reject plaintext upgrades when SSL is enabled#1550
Open
someonegg wants to merge 1 commit into
Open
fix(security): reject plaintext upgrades when SSL is enabled#1550someonegg wants to merge 1 commit into
someonegg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
When ttyd is started with SSL enabled, libwebsockets is configured to allow plaintext HTTP on the SSL port and redirect it to HTTPS. Normal HTTP requests are redirected, but plaintext WebSocket upgrade requests can still be accepted and return
101 Switching Protocols.This means
/wscan be reached over a non-TLS connection even when SSL is enabled. If mTLS is configured with--ssl-ca, client certificate verification only happens during the TLS handshake, so this plaintext upgrade path can bypass the expected client certificate check.This patch rejects all non-TLS HTTP upgrade requests when SSL is enabled.
Testing
cmake -S . -B buildcmake --build buildhttp://127.0.0.1:<port>/returns301 Redirect/wsno longer returns101 Switching Protocolshttps://127.0.0.1:<port>/tokenstill returns200 OK