fix(compat/find): align implementation param names with overload signatures#1824
Open
Antoliny0919 wants to merge 2 commits into
Open
fix(compat/find): align implementation param names with overload signatures#1824Antoliny0919 wants to merge 2 commits into
Antoliny0919 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
Thanks for the contribution! Some of the parameter renames here look good (e.g. |
Antoliny0919
force-pushed
the
find-param-consistency
branch
from
6f35e90 to
58912e5
Compare
Antoliny0919
force-pushed
the
find-param-consistency
branch
from
2633578 to
1d2610b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For consistency, how about using the same parameter names as the overload signatures? 👍