style[banner]: adjust banner content navigation button size#1736
Open
Antoliny0919 wants to merge 2 commits into
Open
style[banner]: adjust banner content navigation button size#1736Antoliny0919 wants to merge 2 commits into
Antoliny0919 wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
I think adding previous/next buttons works better aesthetically than making the dots bigger. |
Contributor
Author
I agree. Adding navigation buttons would be more visually explicit. @raon0211 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The navigation buttons inside the banner located at the bottom right of the screen are too small.(6 * 6)
Even I, who don't usually have difficulty with small buttons, had to attempt clicking two or three times.
According to W3C guidelines, a minimum size of 24 x 24 is recommended.
However, applying this standard to these buttons would likely involve style trade offs.
That said, I still think the button size needs to be increased somewhat, even if it doesn't fully meet the 24 x 24 requirement.
Change
Before (6 * 6)
After (12 * 12)
(If 12 feels a bit too large, 10 would look fine as well 😁)