editor: per-node pin label column width; wider rendergraph nodes by default

Graph_editor_node gains a pin-label-width property (canvas units, default
70, clamped 20..400): the space reserved on each pin edge for the pin
labels, previously hardcoded in node_editor(). Exposed as the Node
Properties "Pin labels" row, persisted in the graph asset JSON and the
node clipboard next to the node size (written only when non-default), and
settable through the *_graph_set_node_layout MCP tools (pin_label_width).

The rendergraph viewer's pin names are long ("rendertarget texture",
"depth visualization"), so its proxy nodes default to a 150 pin label
column and a 520 requested node width - labels no longer clip and the
nodes read comfortably.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: tksuoran

src/editor/developer/rendergraph_window.cpp

@@ -55,6 +55,11 @@ class Rendergraph_editor_node : public Graph_editor_node
         for (const erhe::graph::Pin& pin : rendergraph_node.get_output_pins()) {
             base_make_output_pin(pin.get_key(), pin.get_name());
         }
+        // Rendergraph pin names are long ("rendertarget texture", "depth
+        // visualization"), so reserve wider pin label columns and a wider
+        // node than the graph editors' defaults.
+        set_pin_label_width(150.0f);
+        set_ui_size(520.0f, 0.0f);
     }
 
     [[nodiscard]] auto get_rendergraph_node() const -> erhe::rendergraph::Rendergraph_node* { return m_rendergraph_node; }

src/editor/graph/node_properties.cpp

@@ -277,6 +277,14 @@ void Node_properties_window::graph_editor_node_properties(Graph_editor_window_ba
         }
         ImGui::EndDisabled();
     });
+    m_property_editor.add_entry("Pin labels", [node]() {
+        // Width of the pin label columns on the node edges (canvas units);
+        // labels wider than this clip.
+        float width = node->get_pin_label_width();
+        if (ImGui::DragFloat("##pin_label_width", &width, 1.0f, 20.0f, 400.0f, "%.0f")) {
+            node->set_pin_label_width(width);
+        }
+    });
     // Pin layout: only left / right are implemented by the node renderer, so
     // the combos offer just those two edges (unlike the shader graph's).
     m_property_editor.add_entry("Inputs", [node]() {

src/editor/graph_editor/graph_clipboard.hpp

@@ -72,6 +72,7 @@ auto paste_graph_nodes(
             node->read_parameters(node_json["parameters"]);
         }
         node->set_ui_size(node_json.value("width", 0.0f), node_json.value("height", 0.0f));
+        node->set_pin_label_width(node_json.value("pin_label_width", Graph_editor_node::default_pin_label_width));
         node->set_input_pin_edge (node_json.value("input_edge",  Node_edge::left));
         node->set_output_pin_edge(node_json.value("output_edge", Node_edge::right));
         const ImVec2 node_position{node_json.value("x", 0.0f), node_json.value("y", 0.0f)};

src/editor/graph_editor/graph_editor_node.cpp

@@ -83,6 +83,16 @@ void Graph_editor_node::set_ui_size(const float width, const float height)
     m_ui_height = std::clamp(height, 0.0f, 4096.0f);
 }
 
+auto Graph_editor_node::get_pin_label_width() const -> float
+{
+    return m_pin_label_width;
+}
+
+void Graph_editor_node::set_pin_label_width(const float width)
+{
+    m_pin_label_width = std::clamp(width, 20.0f, 400.0f);
+}
+
 auto Graph_editor_node::get_input_pin_edge() const -> int
 {
     return m_input_pin_edge;
@@ -185,7 +195,7 @@ void Graph_editor_node::node_editor(App_context& app_context, ax::NodeEditor::Ed
     // (or less, down to a minimum) room. NodePadding is part of the node's
     // outer extent, so subtract it to hit the requested canvas-unit width.
     const ImVec4 node_padding    = node_editor.GetStyle().NodePadding; // canvas units: left, top, right, bottom
-    const float  pin_label_width = 70.0f  * m_content_scale;
+    const float  pin_label_width = m_pin_label_width * m_content_scale;
     float        center_width    = 150.0f * m_content_scale;
     if (m_ui_width > 0.0f) {
         const float padding_width = (node_padding.x + node_padding.z) * m_content_scale;

src/editor/graph_editor/graph_editor_node.hpp

@@ -65,6 +65,15 @@ class Graph_editor_node : public erhe::graph::Node
     [[nodiscard]] auto get_ui_height() const -> float;
     void set_ui_size(float width, float height);
 
+    // Pin label column width in canvas units: the space reserved on each pin
+    // edge for the pin labels (labels wider than this clip). Editors whose
+    // pins carry longer names raise it (the rendergraph viewer). Adjusted
+    // from the Node Properties window "Pin labels" row; persisted in the
+    // graph JSON next to the node size.
+    static constexpr float default_pin_label_width = 70.0f;
+    [[nodiscard]] auto get_pin_label_width() const -> float;
+    void set_pin_label_width(float width);
+
     // Pin layout: which node edge the input / output pins are laid out on
     // (Node_edge::left / right; the renderer implements only those two, so
     // the setters clamp anything else back to the default edge). Adjusted
@@ -128,6 +137,7 @@ class Graph_editor_node : public erhe::graph::Node
     float       m_content_scale{1.0f};
     float       m_ui_width {0.0f}; // canvas units; <= 0 = automatic
     float       m_ui_height{0.0f}; // canvas units; <= 0 = automatic
+    float       m_pin_label_width{default_pin_label_width}; // canvas units
     // Bottom of the requested node content extent in screen space (0 = no
     // requested height); set per frame by node_editor(), consumed by the
     // height pad and by get_preview_fit_size().

src/editor/graph_editor/graph_editor_window_base.cpp

@@ -657,6 +657,9 @@ auto Graph_editor_window_base::serialize_nodes_json(const std::vector<std::share
         if (node->get_ui_height() > 0.0f) {
             node_json["height"] = node->get_ui_height();
         }
+        if (node->get_pin_label_width() != Graph_editor_node::default_pin_label_width) {
+            node_json["pin_label_width"] = node->get_pin_label_width();
+        }
         if (node->get_input_pin_edge() != Node_edge::left) {
             node_json["input_edge"] = node->get_input_pin_edge();
         }

src/editor/graph_editor/graph_serialization.hpp

@@ -1,6 +1,7 @@
 #pragma once
 
 #include "editor_log.hpp"
+#include "graph_editor/graph_editor_node.hpp"
 #include "graph_editor/node_edge.hpp"
 
 #include "erhe_graph/graph.hpp"
@@ -51,6 +52,9 @@ template <typename NodeT>
         if (node->get_ui_height() > 0.0f) {
             node_json["height"] = node->get_ui_height();
         }
+        if (node->get_pin_label_width() != Graph_editor_node::default_pin_label_width) {
+            node_json["pin_label_width"] = node->get_pin_label_width();
+        }
         if (node->get_input_pin_edge() != Node_edge::left) {
             node_json["input_edge"] = node->get_input_pin_edge();
         }
@@ -134,6 +138,7 @@ auto read_graph_asset_json(
             node->read_parameters(node_json["parameters"]);
         }
         node->set_ui_size(node_json.value("width", 0.0f), node_json.value("height", 0.0f));
+        node->set_pin_label_width(node_json.value("pin_label_width", Graph_editor_node::default_pin_label_width));
         node->set_input_pin_edge (node_json.value("input_edge",  Node_edge::left));
         node->set_output_pin_edge(node_json.value("output_edge", Node_edge::right));
         new_nodes.push_back(node);

src/editor/mcp/mcp_server_graphs.cpp

@@ -141,6 +141,12 @@ namespace {
         const float height = args.contains("height") ? args["height"].get<float>() : node.get_ui_height();
         node.set_ui_size(width, height);
     }
+    if (args.contains("pin_label_width")) {
+        if (!args["pin_label_width"].is_number()) {
+            return make_error_content("'pin_label_width' must be a number (canvas units)");
+        }
+        node.set_pin_label_width(args["pin_label_width"].get<float>());
+    }
     int edge = 0;
     if (args.contains("input_edge")) {
         if (!parse_node_edge(args["input_edge"], edge)) {
@@ -158,8 +164,9 @@ namespace {
     json result;
     result["node_id"]     = node.get_id();
     result["position"]    = json::array({position.x, position.y});
-    result["width"]       = node.get_ui_width();  // 0 = automatic
-    result["height"]      = node.get_ui_height(); // 0 = automatic
+    result["width"]           = node.get_ui_width();  // 0 = automatic
+    result["height"]          = node.get_ui_height(); // 0 = automatic
+    result["pin_label_width"] = node.get_pin_label_width();
     result["input_edge"]  = (node.get_input_pin_edge()  == Node_edge::right) ? "right" : "left";
     result["output_edge"] = (node.get_output_pin_edge() == Node_edge::right) ? "right" : "left";
     return make_json_content(result).dump();

src/editor/mcp/mcp_server_tool_list.cpp

@@ -977,6 +977,7 @@ void Mcp_server::refresh_tool_list()
             {"position",    {{"type", "array"},   {"items", {{"type", "number"}}}, {"description", "Canvas position [x, y]"}}},
             {"width",       {{"type", "number"},  {"description", "Requested node width in canvas units; 0 = automatic (content-derived)"}}},
             {"height",      {{"type", "number"},  {"description", "Requested node height in canvas units; 0 = automatic (content-derived)"}}},
+            {"pin_label_width", {{"type", "number"}, {"description", "Pin label column width in canvas units (default 70; clamped to 20..400)"}}},
             {"input_edge",  {{"type", "string"},  {"description", "Edge for input pins: left (default) or right"}}},
             {"output_edge", {{"type", "string"},  {"description", "Edge for output pins: left or right (default)"}}}
         }},
@@ -989,6 +990,7 @@ void Mcp_server::refresh_tool_list()
             {"position",    {{"type", "array"},   {"items", {{"type", "number"}}}, {"description", "Canvas position [x, y]"}}},
             {"width",       {{"type", "number"},  {"description", "Requested node width in canvas units; 0 = automatic (content-derived)"}}},
             {"height",      {{"type", "number"},  {"description", "Requested node height in canvas units; 0 = automatic (content-derived)"}}},
+            {"pin_label_width", {{"type", "number"}, {"description", "Pin label column width in canvas units (default 70; clamped to 20..400)"}}},
             {"input_edge",  {{"type", "string"},  {"description", "Edge for input pins: left (default) or right"}}},
             {"output_edge", {{"type", "string"},  {"description", "Edge for output pins: left or right (default)"}}}
         }},