test(agent): parity test backfill — credential scrub + failure classification (#4468)#4509
Conversation
…cation Parity test backfill (tinyhumansai#4468) for behaviors tinyhumansai#4495 shipped without unit coverage: - credentials: bare AWS (AKIA/ASIA), OpenAI (sk-), and space-separated Bearer redaction (tinyhumansai#4453). - tool_status::classify: POLICY_DENIED_MARKER -> Denied (non-recoverable), and a TTL-expiry deny reason (contains 'timed out') -> ApprovalExpired not Timeout (tinyhumansai#4459). Verified via CI (local cargo builds OOM on this box). Claude-Session: https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
More parity backfill (tinyhumansai#4468): - estimate_text_tokens: [IMAGE:...] markers priced at the flat IMAGE_MARKER_TOKEN_COST, not chars/4 of the base64 body (tinyhumansai#4462). - is_subagent_spawn_or_delegate_tool: spawn/delegate/worker tools are always stripped from a child run, ordinary tools are not (tinyhumansai#4452). Claude-Session: https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR
Draft — backfilling unit coverage for tinyagents-migration parity behaviors that #4495 shipped without tests (part of #4468). Using CI to compile/run since local
cargobuilds OOM on my box.Tests added (openhuman)
AKIA/ASIA, OpenAIsk-, and space-separatedBearertoken redaction.POLICY_DENIED_MARKER→Denied(non-recoverable); a TTL-expiry deny reason (contains "timed out") →ApprovalExpired, notTimeout.More parity tests (and the vendored-tinyagents crate tests) to follow on this branch / a companion PR.
Submission Checklist
#[cfg(test)]modules).Refs #4468, #4453, #4459.
https://claude.ai/code/session_019j5TLsRLHsM3kqAYFyH4hR